fix: workflow handler not working outside gui by adiologydev · Pull Request #609 · simstudioai/sim

adiologydev · 2025-07-03T13:59:10Z

Description

Fixes the bug where workflow block handler won't load child workflows when called externally.

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update
Security enhancement
Performance improvement
Code refactoring (no functional changes)

How Has This Been Tested?

Locally deployed and ran.

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added tests that prove my fix is effective or that my feature works
All tests pass locally and in CI (bun run test)
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules
I have updated version numbers as needed (if needed)
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Security Considerations:

My changes do not introduce any new security vulnerabilities
I have considered the security implications of my changes

Additional Information:

Any additional information, configuration or data that might be necessary to reproduce the issue or use the feature.

vercel · 2025-07-03T13:59:37Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
sim	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 3, 2025 2:07pm

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
docs	⬜️ Skipped (Inspect)			Jul 3, 2025 2:07pm

greptile-apps

PR Summary

This pull request fixes a critical bug where the workflow block handler fails to load child workflows when invoked outside of the GUI environment.

Improves external workflow execution by fixing child workflow loading
Bug impacts core workflow functionality when called programmatically outside GUI

_{No files reviewed, no comments}
_{Edit PR Review Bot Settings | Greptile}

delve-auditor · 2025-07-03T14:00:18Z

✅ No security or compliance issues detected. Reviewed everything up to 67039ea.

Security Overview

🔎 Scanned files: 6 changed file(s)

Detected Code Changes

Change Type	Relevant files
Enhancement	► route.ts Add internal API authentication ► internal.ts Add JWT token verification ► store.ts Update workflow creation logic ► utils.ts Refactor workflow name and color generation ► schedule-config.tsx Update schedule checking logic ► workflow-block.tsx Update schedule reactivation flow ► create-menu.tsx Simplify workflow creation UI
Configuration changes	► env.ts Add internal API secret environment variable ► package.json Add jose dependency
Refactor	► sidebar.tsx Simplify workflow creation state management

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

* fix: key to call api internally for workflow block * feat: use jwt for internal auth to avoid a static key * chore: formatter

* feat(logging): add additional logs for proxy routes * fix(blocks): workflow handler not working outside gui (#609) * fix: key to call api internally for workflow block * feat: use jwt for internal auth to avoid a static key * chore: formatter * fix(sidebar): added loop & parallel subblcoks to sidebar search * merged improvement/connection into staging (#604) * merged improvement/connection into staging * fix: merge conflicts and improved block path calculation * fix: removed migration * fix: removed duplicate call * fix: resolver and merge conflicts * fix: knowledge base folder * fix: settings modal * fix: typeform block * fix: parallel handler * fix: stores index * fix: tests * fix: tag-dropdown * improvement: start block input and tag dropdown * fix block id resolution + missing bracket * fix lint * fix test * works * fix * fix lint * Revert "fix lint" This reverts commit 433e2f9. --------- Co-authored-by: Vikhyath Mondreti <vikhyathvikku@gmail.com> Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-MacBook-Air.local> * fix(autopan): migration missing (#614) * add autopan migration * fix lint * fix linter * fix tests --------- Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@vikhyaths-air.lan> --------- Co-authored-by: Waleed Latif <walif6@gmail.com> Co-authored-by: Aditya Tripathi <aditya@climactic.co> Co-authored-by: Emir Karabeg <78010029+emir-karabeg@users.noreply.github.com> Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-MacBook-Air.local> Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@vikhyaths-air.lan>

* fix: key to call api internally for workflow block * feat: use jwt for internal auth to avoid a static key * chore: formatter

* feat(logging): add additional logs for proxy routes * fix(blocks): workflow handler not working outside gui (simstudioai#609) * fix: key to call api internally for workflow block * feat: use jwt for internal auth to avoid a static key * chore: formatter * fix(sidebar): added loop & parallel subblcoks to sidebar search * merged improvement/connection into staging (simstudioai#604) * merged improvement/connection into staging * fix: merge conflicts and improved block path calculation * fix: removed migration * fix: removed duplicate call * fix: resolver and merge conflicts * fix: knowledge base folder * fix: settings modal * fix: typeform block * fix: parallel handler * fix: stores index * fix: tests * fix: tag-dropdown * improvement: start block input and tag dropdown * fix block id resolution + missing bracket * fix lint * fix test * works * fix * fix lint * Revert "fix lint" This reverts commit 433e2f9. --------- Co-authored-by: Vikhyath Mondreti <vikhyathvikku@gmail.com> Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-MacBook-Air.local> * fix(autopan): migration missing (simstudioai#614) * add autopan migration * fix lint * fix linter * fix tests --------- Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@vikhyaths-air.lan> --------- Co-authored-by: Waleed Latif <walif6@gmail.com> Co-authored-by: Aditya Tripathi <aditya@climactic.co> Co-authored-by: Emir Karabeg <78010029+emir-karabeg@users.noreply.github.com> Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-MacBook-Air.local> Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@vikhyaths-air.lan>

adiologydev added 2 commits July 3, 2025 13:26

fix: key to call api internally for workflow block

ce5b344

feat: use jwt for internal auth to avoid a static key

879bf9f

greptile-apps bot reviewed Jul 3, 2025

View reviewed changes

chore: formatter

67039ea

vercel bot temporarily deployed to Preview – docs July 3, 2025 14:02 Inactive

vercel bot deployed to Preview – sim July 3, 2025 14:07 View deployment

waleedlatif1 approved these changes Jul 3, 2025

View reviewed changes

waleedlatif1 merged commit 073a99c into staging Jul 3, 2025
6 checks passed

waleedlatif1 deleted the fix/workflow-in-workflow branch July 3, 2025 21:32

icecrasher321 pushed a commit that referenced this pull request Jul 4, 2025

fix(blocks): workflow handler not working outside gui (#609)

7486d03

* fix: key to call api internally for workflow block * feat: use jwt for internal auth to avoid a static key * chore: formatter

icecrasher321 mentioned this pull request Jul 4, 2025

v0.2.7: fix + feat #615

Merged

13 tasks

aadamgough pushed a commit that referenced this pull request Jul 15, 2025

fix(blocks): workflow handler not working outside gui (#609)

8992658

* fix: key to call api internally for workflow block * feat: use jwt for internal auth to avoid a static key * chore: formatter

aadamgough pushed a commit that referenced this pull request Jul 17, 2025

fix(blocks): workflow handler not working outside gui (#609)

799c064

* fix: key to call api internally for workflow block * feat: use jwt for internal auth to avoid a static key * chore: formatter

aadamgough pushed a commit that referenced this pull request Jul 25, 2025

fix(blocks): workflow handler not working outside gui (#609)

7e9ccae

* fix: key to call api internally for workflow block * feat: use jwt for internal auth to avoid a static key * chore: formatter

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: workflow handler not working outside gui#609

fix: workflow handler not working outside gui#609
waleedlatif1 merged 3 commits intostagingfrom
fix/workflow-in-workflow

adiologydev commented Jul 3, 2025

Uh oh!

vercel bot commented Jul 3, 2025 •

edited

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

delve-auditor bot commented Jul 3, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

adiologydev commented Jul 3, 2025

Description

Type of change

How Has This Been Tested?

Checklist:

Security Considerations:

Additional Information:

Uh oh!

vercel bot commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

delve-auditor bot commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel bot commented Jul 3, 2025 •

edited

Loading

delve-auditor bot commented Jul 3, 2025 •

edited

Loading